Bug 211754

Summary: AtomString::init should temporarily disable checks via `isMainThread` due to WebThread's inconsistent state
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: WebCore Misc.Assignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dino, ews-watchlist, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+
Patch ews-feeder: commit-queue-

Yusuke Suzuki
Reported 2020-05-11 17:13:39 PDT
...
Attachments
Patch (4.54 KB, patch)
2020-05-11 18:44 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2020-05-11 18:51 PDT, Yusuke Suzuki 		dino: review+
DetailsFormatted DiffDiff
Patch (5.55 KB, patch)
2020-05-11 20:03 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-05-11 18:44:43 PDT
Created attachment 399083 [details] Patch
Yusuke Suzuki
Comment 2 2020-05-11 18:51:39 PDT
Created attachment 399084 [details] Patch
Yusuke Suzuki
Comment 3 2020-05-11 19:59:31 PDT
Comment on attachment 399084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399084&action=review > Source/WTF/wtf/NeverDestroyed.h:132 > MaybeRelax<T>(new (storagePointer()) T(std::forward<Args>(args)...)); Oops, I also added `storagePointerWithoutAccessCheck()`.
Yusuke Suzuki
Comment 4 2020-05-11 20:03:22 PDT
Created attachment 399091 [details] Patch Patch for landing
Yusuke Suzuki
Comment 5 2020-05-11 21:58:21 PDT
Comment on attachment 399091 [details] Patch api-ios and WK1 finishes. ios-wk2 is not related since it is not using webthread.
EWS
Comment 6 2020-05-11 21:58:58 PDT
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Yusuke Suzuki
Comment 7 2020-05-11 22:21:34 PDT
Committed r261545: <https://trac.webkit.org/changeset/261545>
Radar WebKit Bug Importer
Comment 8 2020-05-11 22:22:16 PDT
<rdar://problem/63121225>
Note You need to log in before you can comment on or make changes to this bug.