Bug 211749

Summary:

[bmalloc][WTF] Add computing memory size implementation for FreeBSD

Product:

WebKit

Reporter:

Basuke Suzuki <basuke>

Component:

Platform

Assignee:

Basuke Suzuki <basuke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

basuke, benjamin, cdumez, cmarcelo, ddkilzer, ews-watchlist, ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
PATCH	none

Description Basuke Suzuki 2020-05-11 15:11:07 PDT

using sysinfo(3) https://www.freebsd.org/cgi/man.cgi?query=sysinfo&apropos=0&sektion=3&manpath=FreeBSD+9-current&format=html

Comment 1 Basuke Suzuki 2020-05-11 16:06:50 PDT

Created attachment 399063 [details]
PATCH

Comment 2 David Kilzer (:ddkilzer) 2020-05-11 19:31:53 PDT

Comment on attachment 399063 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=399063&action=review

r=me

> Source/WTF/wtf/RAMSize.cpp:60
>      sysinfo(&si);

Should we assert that the return value here is zero (similar to what bmalloc does)?

Would also be nice to use `info` like bmalloc.

Neither of these are necessary to land this patch.

Comment 3 EWS 2020-05-11 20:06:28 PDT

Committed r261543: <https://trac.webkit.org/changeset/261543>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399063 [details].

Comment 4 Radar WebKit Bug Importer 2020-05-11 20:07:14 PDT

<rdar://problem/63117982>