Bug 211741

Summary: Compile with -funwind-tables everywhere so we can always unwind
Product: WebKit Reporter: Saam Barati <saam>
Component: PlatformAssignee: Saam Barati <saam>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap, dino, eric.carlson, ews-watchlist, graouts, jbedard, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, sam, thorton, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 211742    
Bug Blocks:    
Attachments:
Description Flags
patch sam: review+

Saam Barati
Reported 2020-05-11 13:39:50 PDT
This is the default for x86, but not the default for arm64. This means on arm64 we don't be able to unwind past C/C++ frames on arm64 unless we compile with this flag.
Attachments
patch (27.03 KB, patch)
2020-05-11 19:44 PDT, Saam Barati 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-05-11 13:52:01 PDT
<rdar://problem/63104244>
Saam Barati
Comment 2 2020-05-11 19:44:07 PDT
Created attachment 399089 [details] patch
EWS Watchlist
Comment 3 2020-05-11 19:45:19 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Saam Barati
Comment 4 2020-05-13 12:45:17 PDT
We're not going to do this. If we encounter more bugs in the future where this behavior matters, we'd probably choose to align behavior instead on -fno-unwind-tables. And fix bad users relying on unwinding from calling into C API.
Note You need to log in before you can comment on or make changes to this bug.