Bug 211727

Summary:

[Flatpak] pass help argument to flatpak command not to gst-env.py

Product:

WebKit

Reporter:

Víctor M. Jáquez L. <vjaquez>

Component:

Tools / Tests

Assignee:

Víctor M. Jáquez L. <vjaquez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, clopez, pnormand

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
Patch	none

Víctor M. Jáquez L.

Reported 2020-05-11 08:04:07 PDT

When running run-minibrowser --help, for example, with the envvar GST_BUILD_PATH, we get the gst-env.py help, not minibrowser's.

Attachments
Patch (1.44 KB, patch) 2020-05-11 08:08 PDT, Víctor M. Jáquez L.	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Víctor M. Jáquez L.

Comment 1 2020-05-11 08:08:53 PDT

Philippe Normand

Comment 2 2020-05-11 10:01:18 PDT

Comment on attachment 399021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399021&action=review > Tools/flatpak/flatpakutils.py:791 > + request_help = '-h' in args or '--help' in args Is there no better way to handle this?

Víctor M. Jáquez L.

Comment 3 2020-05-13 08:55:49 PDT

(In reply to Philippe Normand from comment #2) > Comment on attachment 399021 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399021&action=review > > > Tools/flatpak/flatpakutils.py:791 > > + request_help = '-h' in args or '--help' in args > > Is there no better way to handle this? I'm sure there should be one, but I can't see it :S

Víctor M. Jáquez L.

Comment 4 2020-05-27 07:04:51 PDT

reopen. I thought it was other bug.

Víctor M. Jáquez L.

Comment 5 2020-05-29 10:02:09 PDT

fixed by commit r262297

Note You need to log in before you can comment on or make changes to this bug.