Bug 211708

Summary: Web Inspector: show JavaScript Worker name as an internal property
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207347
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-05-10 19:02:09 PDT
.
Attachments
Patch (8.97 KB, patch)
2020-05-10 19:05 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-05-10 19:05:33 PDT
Created attachment 398992 [details] Patch
Joseph Pecoraro
Comment 2 2020-05-10 19:27:38 PDT
Comment on attachment 398992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398992&action=review > Source/WebCore/ChangeLog:3 > + Web Inspector: show JavaScript Worker name as an internal property Curious! Is there no public getter for the Worker's name?! Should we propose this for the standard?
Devin Rousso
Comment 3 2020-05-11 10:40:27 PDT
Comment on attachment 398992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398992&action=review >> Source/WebCore/ChangeLog:3 >> + Web Inspector: show JavaScript Worker name as an internal property > > Curious! Is there no public getter for the Worker's name?! Should we propose this for the standard? It looks like it's accessible as a readonly attribute on `DedicatedWorkerGlobalScope`, but not the corresponding `Worker`. I don't have a strong opinion about whether it should be standardized. Could be useful I guess? The primary motivation for this IIRC was for developer tooling anyways, so ¯\_(ツ)_/¯
EWS
Comment 4 2020-05-11 15:42:22 PDT
Committed r261499: <https://trac.webkit.org/changeset/261499> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398992 [details].
Radar WebKit Bug Importer
Comment 5 2020-05-11 15:43:14 PDT
<rdar://problem/63109139>
Yusuke Suzuki
Comment 6 2020-05-11 15:56:01 PDT
Nice!
Note You need to log in before you can comment on or make changes to this bug.