| Summary: | [clang-tidy] Run modernize-use-nullptr over JSC | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2020-05-10 16:44:28 PDT
Created attachment 398987 [details]
Patch
Comment on attachment 398987 [details]
Patch
Looks fine. rs=me if there isn’t a mistake here somewhere that breaks compilation
Thanks! For the record, this patch is the result of running the following command: run-clang-tidy.py Source/JavaScriptCore -fix -checks="-*,modernize-use-nullptr" -header-filter="Source/*"` None of changes under the API subdirectory are to C header declarations, so everything appears to be safe here. Comment on attachment 398987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398987&action=review > Source/JavaScriptCore/parser/Parser.cpp:2251 > - context.appendParameter(parameterList, parameter, 0); > + context.appendParameter(parameterList, parameter, nullptr); EWS failures are about code like this. This is template code and the SyntaxChecker.h use of it will need to be changed. It uses int for this, and could instead use void* or virtually any pointer type. (In reply to Darin Adler from comment #4) > Comment on attachment 398987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398987&action=review > > > Source/JavaScriptCore/parser/Parser.cpp:2251 > > - context.appendParameter(parameterList, parameter, 0); > > + context.appendParameter(parameterList, parameter, nullptr); > > EWS failures are about code like this. This is template code and the > SyntaxChecker.h use of it will need to be changed. It uses int for this, and > could instead use void* or virtually any pointer type. I think I'll split that out into a second patch just to keep this one fully-automated. Created attachment 398991 [details]
Patch for landing
Committed r261464: <https://trac.webkit.org/changeset/261464> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398991 [details]. |