Bug 211691

Summary: [WebGPU] Implement texture views
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: NEW    
Severity: Normal CC: annulen, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 211882    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
Rebased none

Myles C. Maxfield
Reported 2020-05-10 02:40:20 PDT
[WebGPU] Implement texture views
Attachments
WIP (32.30 KB, patch)
2020-05-10 02:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Rebased (30.80 KB, patch)
2020-05-19 00:15 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-05-10 02:42:17 PDT
Created attachment 398970 [details] WIP
Myles C. Maxfield
Comment 2 2020-05-10 02:42:20 PDT
<rdar://problem/54533652>
Myles C. Maxfield
Comment 3 2020-05-10 02:42:47 PDT
Comment on attachment 398970 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=398970&action=review > Source/WebCore/ChangeLog:11 > + - Figure out what to do about GPUTextureAspect Also delete createDefaultView(), and make sure default values work.
Myles C. Maxfield
Comment 4 2020-05-10 02:44:42 PDT
Comment on attachment 398970 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=398970&action=review >> Source/WebCore/ChangeLog:11 >> + - Figure out what to do about GPUTextureAspect > > Also delete createDefaultView(), and make sure default values work. Also also: Write all the stuff in this patch in the spec: https://gpuweb.github.io/gpuweb/#textureview-createview
Myles C. Maxfield
Comment 5 2020-05-10 19:55:52 PDT
Comment on attachment 398970 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=398970&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:360 > + texture = adoptNS([m_platformTexture newTextureViewWithPixelFormat:metalPixelFormat textureType:textureType.value() levels:levels.value() slices:slices.value()]); If the view is the same as the underlying texture, we can avoid this call.
Myles C. Maxfield
Comment 6 2020-05-18 23:49:51 PDT
From the spec: > optional GPUTextureViewDescriptor descriptor = {} This doesn't make sense to me.
Myles C. Maxfield
Comment 7 2020-05-19 00:15:48 PDT
Created attachment 399714 [details] Rebased
Myles C. Maxfield
Comment 8 2020-05-19 00:17:26 PDT
mipLevelCount: If 0, defaults to texture.mipLevelCount − baseMipLevel. arrayLayerCount: If 0, defaults to texture.size.depth − baseArrayLayer.
Myles C. Maxfield
Comment 9 2020-05-19 00:18:26 PDT
> If texture.size.depth is greater than 1 and arrayLayerCount is 0 This seems kind of silly
Myles C. Maxfield
Comment 10 2020-05-20 12:34:28 PDT
Comment on attachment 399714 [details] Rebased View in context: https://bugs.webkit.org/attachment.cgi?id=399714&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:308 > + return parentSampleCount == 1 ? MTLTextureType2DArray : MTLTextureType2DMultisampleArray; MTLTextureType2DMultisampleArray doesn't exist on iOS
Note You need to log in before you can comment on or make changes to this bug.