Bug 211662

Summary: Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI
Product: WebKit Reporter: David Quesada <david_quesada>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

David Quesada
Reported 2020-05-08 23:45:56 PDT
On all UIKit-having platforms that WebKit suports building for, UIScrollView has the SPI -_flashScrollIndicatorsForAxes:persistingPreviousFlashes:. The HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI platform conditional is therefore no longer necessary, and its current NO value for Mac Catalyst actually makes us send a message (_flashScrollIndicatorsPersistingPreviousFlashes:) that UIScrollView no longer responds to.
Attachments
Patch (5.62 KB, patch)
2020-05-08 23:55 PDT, David Quesada 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-05-08 23:46:15 PDT
<rdar://problem/63048713>
David Quesada
Comment 2 2020-05-08 23:55:21 PDT
Created attachment 398920 [details] Patch
Darin Adler
Comment 3 2020-05-09 08:38:53 PDT
Comment on attachment 398920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398920&action=review > Source/WebKit/ChangeLog:12 > + Remove this platform conditional and unconditionally use -[UIScrolView _flashScrollIndicatorsForAxes: > + persistingPreviousFlashes:]. All supported platforms with UIScrollView have this SPI, and the conditional > + was excluding Mac Catalyst, making WKKeyboardScrollViewAnimator send a message to its scroll view that > + is no longer implemented. Seems like the headline here is fixing the bug on Mac Catalyst; a crash maybe? Removing the HAVE macro is the less important half of this, as grateful as I am to have that cleaned up too.
EWS
Comment 4 2020-05-09 09:02:31 PDT
Committed r261436: <https://trac.webkit.org/changeset/261436> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398920 [details].
Note You need to log in before you can comment on or make changes to this bug.