Bug 211642

Summary: webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation'
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, giffypap79, glenn, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-05-08 13:58:15 PDT
In general, model matching should work such that '<model> 1st generation' matches '<model>'
Attachments
Patch (4.76 KB, patch)
2020-05-08 14:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (6.96 KB, patch)
2020-05-08 15:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.96 KB, patch)
2020-05-08 15:09 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-05-08 14:00:05 PDT
<rdar://problems/62986242>
Jonathan Bedard
Comment 2 2020-05-08 14:03:28 PDT
Created attachment 398886 [details] Patch
Aakash Jain
Comment 3 2020-05-08 14:18:31 PDT
Comment on attachment 398886 [details] Patch rs=me
Alexey Proskuryakov
Comment 4 2020-05-08 14:46:45 PDT
Comment on attachment 398886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398886&action=review > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:164 > + self.assertTrue(DeviceType.from_string('iPhone SE') == DeviceType.from_string('iPhone SE 1st generation')) Is this the actual string? I thought that there were parentheses there.
Jonathan Bedard
Comment 5 2020-05-08 15:03:08 PDT
Created attachment 398893 [details] Patch
Jonathan Bedard
Comment 6 2020-05-08 15:06:57 PDT
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 398886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398886&action=review > > > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:164 > > + self.assertTrue(DeviceType.from_string('iPhone SE') == DeviceType.from_string('iPhone SE 1st generation')) > > Is this the actual string? I thought that there were parentheses there. There are, and I missed a check we need in the case that we don't have an existing simulator with the type. Uploaded a new patch.
Jonathan Bedard
Comment 7 2020-05-08 15:09:57 PDT
Created attachment 398896 [details] Patch for landing
EWS
Comment 8 2020-05-08 15:56:52 PDT
Committed r261421: <https://trac.webkit.org/changeset/261421> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398896 [details].
Note You need to log in before you can comment on or make changes to this bug.