| Summary: | Fix wpt shadow-dom/slots-fallback-in-document.html | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tetsuharu Ohzeki [UTC+9] <tetsuharu.ohzeki> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 148695 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tetsuharu Ohzeki [UTC+9]
2020-05-08 12:46:20 PDT
I'll attach the patch. Created attachment 398885 [details]
Patch
Comment on attachment 398885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398885&action=review > Source/WebCore/html/HTMLSlotElement.cpp:123 > - if (is<HTMLSlotElement>(*node)) > + if (is<HTMLSlotElement>(*node) && downcast<HTMLSlotElement>(*node).containingShadowRoot()) Why is this different from the code above that iterates children? (In reply to Darin Adler from comment #3) > Comment on attachment 398885 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398885&action=review > > > Source/WebCore/html/HTMLSlotElement.cpp:123 > > - if (is<HTMLSlotElement>(*node)) > > + if (is<HTMLSlotElement>(*node) && downcast<HTMLSlotElement>(*node).containingShadowRoot()) > > Why is this different from the code above that iterates children? This condition changing is correspond to the spec[1], step 5-1-1. [1]: https://dom.spec.whatwg.org/#find-flattened-slotables As sideeffect, this change also fix http://wpt.live/shadow-dom/slots-outside-shadow-dom.html. I'll upload the patch which updates wpt results. Created attachment 398919 [details]
Patch
Are you a committer? If not, can you also set cq? when your patch is ready to land. Then any committer (including myself) can set it to cq+, which allows your patch to be committed into the WebKit repository. (In reply to Ryosuke Niwa from comment #7) > Are you a committer? If not, can you also set cq? when your patch is ready > to land. Then any committer (including myself) can set it to cq+, which > allows your patch to be committed into the WebKit repository. You can do this via "Details". (In reply to Ryosuke Niwa from comment #7) > Are you a committer? If not, can you also set cq? when your patch is ready > to land. Then any committer (including myself) can set it to cq+, which > allows your patch to be committed into the WebKit repository. Thank you for your guide, niwa san. I'm not a comitter, so I'll set cq?. Comment on attachment 398919 [details]
Patch
Great. Thanks for the patch!
Committed r261433: <https://trac.webkit.org/changeset/261433> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398919 [details]. |