Bug 211591

Summary: [iOS] caret appears in the middle of a search field when field is focused on agoda.com
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, esprehn+autocc, ews-watchlist, graouts, graouts, kangil.han, megan_gardner, mifenton, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix #include order
none
Rebase on trunk
none
Patch
none
Remove unnecessary local variable none

Description Wenson Hsieh 2020-05-07 13:06:28 PDT 
<rdar://problem/60605873>
Comment 1 Wenson Hsieh 2020-05-07 13:46:03 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-05-07 13:48:49 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-05-07 14:45:05 PDT Comment hidden (obsolete)
Comment 4 Antoine Quint 2020-05-08 01:22:24 PDT 
I'd rather we didn't add the animationDidFinish() method on AnimationEffect/KeyframeEffect. The other animationDid*() method are there because KeyframeEffect need to update accelerated animations based on a timing change in its associated WebAnimation, but here this is not the case. I suggest we simply call through KeyframeEffect to obtain the target right from WebAnimation::finishNotificationSteps() leaving AnimationEffect/KeyframeEffect untouched.
Comment 5 Wenson Hsieh 2020-05-08 07:07:55 PDT 
Comment on attachment 398799 [details]
Rebase on trunk

(In reply to Antoine Quint from comment #4)
> I'd rather we didn't add the animationDidFinish() method on
> AnimationEffect/KeyframeEffect. The other animationDid*() method are there
> because KeyframeEffect need to update accelerated animations based on a
> timing change in its associated WebAnimation, but here this is not the case.
> I suggest we simply call through KeyframeEffect to obtain the target right
> from WebAnimation::finishNotificationSteps() leaving
> AnimationEffect/KeyframeEffect untouched.

👍🏻
Comment 6 Wenson Hsieh 2020-05-08 07:45:18 PDT Comment hidden (obsolete)
Comment 7 Wenson Hsieh 2020-05-08 07:47:21 PDT 
Created attachment 398860 [details]
Remove unnecessary local variable
Comment 8 EWS 2020-05-08 10:57:44 PDT 
Committed r261398: <https://trac.webkit.org/changeset/261398>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398860 [details].