Bug 211584

Summary: webkitpy: Use apple_additions certificate path if available
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-05-07 10:45:52 PDT
We should use the certificate path form apple_additions if it's available.
Attachments
Patch (2.50 KB, patch)
2020-05-07 10:49 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2020-05-07 11:36 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.50 KB, patch)
2020-05-07 12:40 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-05-07 10:49:25 PDT
Created attachment 398762 [details] Patch
Jonathan Bedard
Comment 2 2020-05-07 11:36:06 PDT
Created attachment 398770 [details] Patch
Aakash Jain
Comment 3 2020-05-07 12:01:16 PDT
Comment on attachment 398770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398770&action=review > Tools/Scripts/webkitpy/results/upload.py:185 > + import certifi Do all the machine have certifi? Should we have a try except here?
Jonathan Bedard
Comment 4 2020-05-07 12:14:58 PDT
(In reply to Aakash Jain from comment #3) > Comment on attachment 398770 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398770&action=review > > > Tools/Scripts/webkitpy/results/upload.py:185 > > + import certifi > > Do all the machine have certifi? Should we have a try except here? Yes. It's a dependency of requests, which we autoinstall in this file. So it's guaranteed to be on your Python path.
Aakash Jain
Comment 5 2020-05-07 12:17:33 PDT
rs=me
Jonathan Bedard
Comment 6 2020-05-07 12:40:47 PDT
Created attachment 398776 [details] Patch for landing
EWS
Comment 7 2020-05-07 13:16:03 PDT
Committed r261332: <https://trac.webkit.org/changeset/261332> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398776 [details].
Radar WebKit Bug Importer
Comment 8 2020-05-07 13:17:14 PDT
<rdar://problem/62990117>
Note You need to log in before you can comment on or make changes to this bug.