Bug 211525

Summary: Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, annulen, ews-watchlist, gyuyoung.kim, mifenton, ryuan.choi, sergio, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Darin Adler 2020-05-06 12:35:41 PDT 
Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
Comment 1 Darin Adler 2020-05-06 12:47:19 PDT 
Created attachment 398646 [details]
Patch
Comment 2 Anders Carlsson 2020-05-07 07:03:14 PDT 
Comment on attachment 398646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398646&action=review

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:-340
> -void PageClientImpl::registerInsertionUndoGrouping()

Surprised that this can be removed when registerInsertionUndoGrouping() is pure virtual...
Comment 3 Wenson Hsieh 2020-05-07 08:51:00 PDT 
Comment on attachment 398646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398646&action=review

>> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:-340
>> -void PageClientImpl::registerInsertionUndoGrouping()
> 
> Surprised that this can be removed when registerInsertionUndoGrouping() is pure virtual...

registerInsertionUndoGrouping() is only declared for PLATFORM(MAC).
Comment 4 Darin Adler 2020-05-07 11:21:38 PDT 
Comment on attachment 398646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398646&action=review

>>> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:-340
>>> -void PageClientImpl::registerInsertionUndoGrouping()
>> 
>> Surprised that this can be removed when registerInsertionUndoGrouping() is pure virtual...
> 
> registerInsertionUndoGrouping() is only declared for PLATFORM(MAC).

Yes, that’s right.
Comment 5 EWS 2020-05-07 11:37:37 PDT 
Committed r261320: <https://trac.webkit.org/changeset/261320>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398646 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-07 11:38:16 PDT 
<rdar://problem/62985963>