Bug 211480

Summary: [Quirk] Job listing page goes blank when scrolling on stackoverflow.com
Product: WebKit Reporter: zalan <zalan>
Component: Page LoadingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2020-05-05 17:21:16 PDT
<rdar://problem/62558405>
Attachments
Patch (8.46 KB, patch)
2020-05-05 17:30 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (8.48 KB, patch)
2020-05-05 18:47 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-05-05 17:30:21 PDT
Created attachment 398572 [details] Patch
Wenson Hsieh
Comment 2 2020-05-05 17:42:19 PDT
Comment on attachment 398572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398572&action=review > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1370 > +static RecommedDesktopClassBrowsingForRequest desktopClassBrowsingRecommendedForRequest(const WebCore::ResourceRequest& request) “Recommed" > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1443 > + return RecommedDesktopClassBrowsingForRequest::Always; Nit - it’s not immediately obvious to me what the difference between Always and Yes is, and I find the asymmetry between No and Yes a bit odd. That said, it’s admittedly hard to come up with a good name for this :/ What do you think about just No, Yes, Auto?
zalan
Comment 3 2020-05-05 18:37:05 PDT
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 398572 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398572&action=review > > > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1370 > > +static RecommedDesktopClassBrowsingForRequest desktopClassBrowsingRecommendedForRequest(const WebCore::ResourceRequest& request) > > “Recommed" > > > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1443 > > + return RecommedDesktopClassBrowsingForRequest::Always; > > Nit - it’s not immediately obvious to me what the difference between Always > and Yes is, and I find the asymmetry between No and Yes a bit odd. That > said, it’s admittedly hard to come up with a good name for this :/ > > What do you think about just No, Yes, Auto? Yeah I wasn't too happy about the naming either. Let me think a bit.
zalan
Comment 4 2020-05-05 18:47:31 PDT
Created attachment 398576 [details] Patch
EWS
Comment 5 2020-05-05 20:08:48 PDT
Committed r261209: <https://trac.webkit.org/changeset/261209> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398576 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-05 20:09:15 PDT
<rdar://problem/62914831>
Note You need to log in before you can comment on or make changes to this bug.