Bug 211473

Summary: fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215778
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-05-05 14:51:40 PDT
fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS.
Attachments
Patch (3.23 KB, patch)
2020-05-05 14:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.27 KB, patch)
2020-05-05 15:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-05-05 14:55:39 PDT
<rdar://problem/61180247>
Chris Dumez
Comment 2 2020-05-05 14:55:47 PDT
Created attachment 398554 [details] Patch
Darin Adler
Comment 3 2020-05-05 15:06:12 PDT
Comment on attachment 398554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398554&action=review > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:20 > + window.sessionStorage.horizontal_scroll_after_back_test_started = true; I don’t think we need the "window." here. > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:30 > + window.setTimeout("navigateAwayAndBack()", 0); I don’t think we need the "window." here. > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:37 > + if (!window.sessionStorage.horizontal_scroll_after_back_test_started) > + return; > + delete window.sessionStorage.horizontal_scroll_after_back_test_started; I don’t think we need the "window." here.
Chris Dumez
Comment 4 2020-05-05 15:07:32 PDT
Created attachment 398556 [details] Patch
EWS
Comment 5 2020-05-05 16:12:35 PDT
Committed r261205: <https://trac.webkit.org/changeset/261205> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398556 [details].
Note You need to log in before you can comment on or make changes to this bug.