| Summary: | Remove orphaned WPT expectations & unused harness | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||
| Component: | Tools / Tests | Assignee: | Alexey Shvayka <ashvayka> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | darin, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Shvayka
2020-05-05 09:57:10 PDT
Comment hidden (obsolete)
Created attachment 398523 [details]
Patch
(In reply to Alexey Shvayka from comment #1) > Created attachment 398523 [details] > Patch Thanks for review! With this patch, we still have 3 copies of idlharness.js and WebIDLParser.js (each): at LayoutTests/resources, LayoutTests/imported/w3c/web-platform-tests/resources, and for a few tests imported from Opera (currently skipped). I wonder if it's a good idea to remove outdated versions and use only WPT upstream ones? There are only a 3-4 non-imported tests that use idlharness.js and interfaces they are testing are probably covered by WPT. Apart from saving bandwidth, the upside is always being up to date with WebIDL spec and avoid partly "syncing" idlharness.js like we did in r260992. Downside: when syncing wpt/resources, expectations for a few non-imported tests should be updated. Committed r261235: <https://trac.webkit.org/changeset/261235> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398523 [details]. |