Bug 211451

Summary: Check for app-bound domains should confirm WKAppBoundDomains key exists when checking for default app-bound protocols.
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kate Cheney
Reported 2020-05-05 09:13:07 PDT
Currently, the app-bound domains check returns true for special protocols without checking for the WKAppBoundDomains key.
Attachments
Patch (3.18 KB, patch)
2020-05-05 10:11 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.19 KB, patch)
2020-05-05 11:20 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2020-05-05 10:11:25 PDT
Created attachment 398521 [details] Patch
Kate Cheney
Comment 2 2020-05-05 10:11:58 PDT
<rdar://problem/62715316>
Kate Cheney
Comment 3 2020-05-05 10:23:24 PDT
I confirmed this fix works manually. I was unable to write a test case for the empty WKAppBoundDomains case because TestWebKitAPI has the key in its Info.plist for other tests.
Brent Fulgham
Comment 4 2020-05-05 11:06:07 PDT
Comment on attachment 398521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398521&action=review Looks good. r=me. > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:465 > + // Must check for both an empty app bound domains and an empty key before returning nullopt "both an empty app bound domains ..." maybe add set? or array? -- the plural domains with the 'an' is throwing me off.
Kate Cheney
Comment 5 2020-05-05 11:20:17 PDT
Created attachment 398529 [details] Patch for landing
EWS
Comment 6 2020-05-05 11:56:36 PDT
Committed r261187: <https://trac.webkit.org/changeset/261187> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398529 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-05 11:57:18 PDT
<rdar://problem/62897375>
Note You need to log in before you can comment on or make changes to this bug.