| Summary: | Check for app-bound domains should confirm WKAppBoundDomains key exists when checking for default app-bound protocols. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||
| Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer, wilander | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Kate Cheney
2020-05-05 09:13:07 PDT
Created attachment 398521 [details]
Patch
I confirmed this fix works manually. I was unable to write a test case for the empty WKAppBoundDomains case because TestWebKitAPI has the key in its Info.plist for other tests. Comment on attachment 398521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398521&action=review Looks good. r=me. > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:465 > + // Must check for both an empty app bound domains and an empty key before returning nullopt "both an empty app bound domains ..." maybe add set? or array? -- the plural domains with the 'an' is throwing me off. Created attachment 398529 [details]
Patch for landing
Committed r261187: <https://trac.webkit.org/changeset/261187> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398529 [details]. |