Bug 211403

Summary: WKWebView.title should be safe browsing warning's title during a safe browsing warning
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2020-05-04 15:02:26 PDT
WKWebView.title should be safe browsing warning's title during a safe browsing warning
Attachments
Patch (3.45 KB, patch)
2020-05-04 15:03 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.79 KB, patch)
2020-05-07 14:17 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-05-04 15:03:27 PDT
Created attachment 398422 [details] Patch
Alex Christensen
Comment 2 2020-05-04 15:03:30 PDT
<rdar://problem/56201982>
Tim Horton
Comment 3 2020-05-04 23:37:01 PDT
Comment on attachment 398422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398422&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:5213 > + m_pageLoadState.setTitle(transaction, oldTitle); I don't really know how this all works, is there a guarantee that neither parsing nor JS have changed the title in the meantime, that you'll lose/stomp here?
Alex Christensen
Comment 4 2020-05-05 09:11:19 PDT
There is no such guarantee. This is just a best attempt at restoring what was there. The title is from a non-malicious page.
Alex Christensen
Comment 5 2020-05-07 14:17:53 PDT
Created attachment 398796 [details] Patch
EWS
Comment 6 2020-05-08 10:13:41 PDT
Committed r261390: <https://trac.webkit.org/changeset/261390> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398796 [details].
Note You need to log in before you can comment on or make changes to this bug.