Bug 211403 - WKWebView.title should be safe browsing warning's title during a safe browsing warning
Summary: WKWebView.title should be safe browsing warning's title during a safe browsin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-04 15:02 PDT by Alex Christensen
Modified: 2020-05-08 10:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.45 KB, patch)
2020-05-04 15:03 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2020-05-07 14:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-05-04 15:02:26 PDT 
WKWebView.title should be safe browsing warning's title during a safe browsing warning
Comment 1 Alex Christensen 2020-05-04 15:03:27 PDT 
Created attachment 398422 [details]
Patch
Comment 2 Alex Christensen 2020-05-04 15:03:30 PDT 
<rdar://problem/56201982>
Comment 3 Tim Horton 2020-05-04 23:37:01 PDT 
Comment on attachment 398422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398422&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:5213
> +                m_pageLoadState.setTitle(transaction, oldTitle);

I don't really know how this all works, is there a guarantee that neither parsing nor JS have changed the title in the meantime, that you'll lose/stomp here?
Comment 4 Alex Christensen 2020-05-05 09:11:19 PDT 
There is no such guarantee.  This is just a best attempt at restoring what was there.  The title is from a non-malicious page.
Comment 5 Alex Christensen 2020-05-07 14:17:53 PDT 
Created attachment 398796 [details]
Patch
Comment 6 EWS 2020-05-08 10:13:41 PDT 
Committed r261390: <https://trac.webkit.org/changeset/261390>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398796 [details].