Summary: | Google Maps rendering corruption in simulator with ANGLE | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||
Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, ap, dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
James Darpinian
2020-05-04 14:02:01 PDT
Created attachment 398412 [details]
Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride.
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 398412 [details] Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride. View in context: https://bugs.webkit.org/attachment.cgi?id=398412&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:86 > + mRowStrideInPixels(0), Don't you use initializer lists in the header in ANGLE? > Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:98 > + // Hopefully the number of bytes per row is always an integer number of pixels. I'd put a blank line above this, but that can also be done upstream. Committed r261322: <https://trac.webkit.org/changeset/261322> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398412 [details]. |