Bug 211398

Summary: Google Maps rendering corruption in simulator with ANGLE
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride. none

James Darpinian
Reported 2020-05-04 14:02:01 PDT
Google Maps rendering corruption in simulator with ANGLE
Attachments
Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride. (3.67 KB, patch)
2020-05-04 14:10 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-05-04 14:10:53 PDT
Created attachment 398412 [details] Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride.
EWS Watchlist
Comment 2 2020-05-04 14:11:39 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Alex Christensen
Comment 3 2020-05-07 11:38:48 PDT
Comment on attachment 398412 [details] Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride. View in context: https://bugs.webkit.org/attachment.cgi?id=398412&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:86 > + mRowStrideInPixels(0), Don't you use initializer lists in the header in ANGLE? > Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:98 > + // Hopefully the number of bytes per row is always an integer number of pixels. I'd put a blank line above this, but that can also be done upstream.
EWS
Comment 4 2020-05-07 11:42:25 PDT
Committed r261322: <https://trac.webkit.org/changeset/261322> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398412 [details].
Radar WebKit Bug Importer
Comment 5 2020-05-07 11:43:15 PDT
<rdar://problem/62986285>
Note You need to log in before you can comment on or make changes to this bug.