Bug 211368

Summary: Remove some unused and broken functions in Bitmap.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2020-05-03 23:22:15 PDT
Bitmap::operator[] never worked. There's currently no way to use it to read a bit value. We also can't use it to set a bit value because it relies on Bitmap::iterator::operator= to set the value. However, Bitmap::iterator stores the Bitmap* as a const pointer, and Bitmap::iterator::operator= calls set() on the const pointer. If we try to use operator[] to set a bit, we'll get a compilation error. This patch removes the 2 variants of Bitmap::operator[] and Bitmap::iterator::operator=.
Attachments
proposed patch. (2.82 KB, patch)
2020-05-03 23:34 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-05-03 23:34:12 PDT
Created attachment 398348 [details] proposed patch.
Yusuke Suzuki
Comment 2 2020-05-04 00:01:25 PDT
Comment on attachment 398348 [details] proposed patch. r=me
Mark Lam
Comment 3 2020-05-04 00:15:58 PDT
Thanks for the review. Landed in r261073: <http://trac.webkit.org/r261073>.
Radar WebKit Bug Importer
Comment 4 2020-05-04 00:16:15 PDT
<rdar://problem/62834067>
Note You need to log in before you can comment on or make changes to this bug.