Bug 211359

Summary: [Intl] Alphabetize extension keys and correctly mark const methods
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2020-05-03 13:58:41 PDT
[Intl] Alphabetize extension keys and correctly mark const methods
Attachments
Patch (20.61 KB, patch)
2020-05-03 14:33 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.58 KB, patch)
2020-05-05 10:40 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-05-03 14:33:49 PDT
Created attachment 398333 [details] Patch
Darin Adler
Comment 2 2020-05-05 10:29:42 PDT
Comment on attachment 398333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398333&action=review > Source/JavaScriptCore/runtime/IntlCollator.cpp:47 > +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" }; There’s a redundant const here. Given constexpr, don’t need the const after the "*".
Ross Kirsling
Comment 3 2020-05-05 10:39:59 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 398333 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398333&action=review > > > Source/JavaScriptCore/runtime/IntlCollator.cpp:47 > > +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" }; > > There’s a redundant const here. Given constexpr, don’t need the const after > the "*". Oops, thanks for pointing that out! Looks like a typo from an earlier patch.
Ross Kirsling
Comment 4 2020-05-05 10:40:53 PDT
Created attachment 398527 [details] Patch for landing
EWS
Comment 5 2020-05-05 11:21:38 PDT
Committed r261182: <https://trac.webkit.org/changeset/261182> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398527 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-05 11:22:17 PDT
<rdar://problem/62895849>
Note You need to log in before you can comment on or make changes to this bug.