| Summary: | [Intl] Alphabetize extension keys and correctly mark const methods | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2020-05-03 13:58:41 PDT
Created attachment 398333 [details]
Patch
Comment on attachment 398333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398333&action=review > Source/JavaScriptCore/runtime/IntlCollator.cpp:47 > +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" }; There’s a redundant const here. Given constexpr, don’t need the const after the "*". (In reply to Darin Adler from comment #2) > Comment on attachment 398333 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398333&action=review > > > Source/JavaScriptCore/runtime/IntlCollator.cpp:47 > > +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" }; > > There’s a redundant const here. Given constexpr, don’t need the const after > the "*". Oops, thanks for pointing that out! Looks like a typo from an earlier patch. Created attachment 398527 [details]
Patch for landing
Committed r261182: <https://trac.webkit.org/changeset/261182> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398527 [details]. |