Bug 211356

Summary: Put lh / rlh units behind a flag until bug 211351 is sorted out.
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: CSSAssignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, mmaxfield, ntim, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 211351    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Emilio Cobos Álvarez (:emilio)
Reported 2020-05-03 12:18:15 PDT
See bug 211351 and the referenced CSSWG issue.
Attachments
Patch (14.65 KB, patch)
2020-05-03 12:29 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch (14.66 KB, patch)
2020-05-03 13:34 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch (15.33 KB, patch)
2020-05-03 14:24 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez (:emilio)
Comment 1 2020-05-03 12:29:31 PDT
Created attachment 398323 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 2 2020-05-03 13:34:46 PDT
Created attachment 398329 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 3 2020-05-03 14:24:09 PDT
Created attachment 398331 [details] Patch
EWS
Comment 4 2020-05-04 00:16:54 PDT
Committed r261074: <https://trac.webkit.org/changeset/261074> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398331 [details].
Radar WebKit Bug Importer
Comment 5 2020-05-04 00:17:16 PDT
<rdar://problem/62834090>
Myles C. Maxfield
Comment 6 2023-01-03 11:43:29 PST
Soooo, sounds like this patch should be reverted, because bug 211351 is sorted out? (Or the flag should be flipped to on-by-default?)
Tim Nguyen (:ntim)
Comment 7 2023-01-03 13:26:17 PST
(In reply to Myles C. Maxfield from comment #6) > Soooo, sounds like this patch should be reverted, because bug 211351 is > sorted out? (Or the flag should be flipped to on-by-default?) It was done in October: https://bugs.webkit.org/show_bug.cgi?id=246522
Note You need to log in before you can comment on or make changes to this bug.