Bug 211351
| Summary: | lh / rlh units don't work properly for some elements. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Emilio Cobos Álvarez (:emilio) <emilio> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bfulgham, koivisto, ntim, rune.lillesveen, simon.fraser, twilco.o, tyler_w, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 211356 | ||
| Bug Blocks: | 195180 | ||
Emilio Cobos Álvarez (:emilio)
There's a bunch of setLineHeight calls in RenderTheme / StyleAdjuster that happen when all other CSS values have already been computed.
So the lh units will refer to a line-height that's fundamentally wrong.
I filed https://github.com/w3c/csswg-drafts/issues/3257 on that a while ago but it seems WebKit has implemented the broken behavior :(
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Emilio Cobos Álvarez (:emilio)
Ah, that's a MainThreadNeverDestroyed, introduced by:
https://bugs.webkit.org/show_bug.cgi?id=211264
So this is a regression from that change.
Yusuke Suzuki
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
> Ah, that's a MainThreadNeverDestroyed, introduced by:
>
> https://bugs.webkit.org/show_bug.cgi?id=211264
>
> So this is a regression from that change.
Could you upload the crash trace of this? If non main thread is touching `const AtomString` generated by `MainThreadNeverDestroyed<>`, this potentially means that `MainThreadNeverDestroyed<>` finds the real bug.
Yusuke Suzuki
(In reply to Yusuke Suzuki from comment #2)
> (In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
> > Ah, that's a MainThreadNeverDestroyed, introduced by:
> >
> > https://bugs.webkit.org/show_bug.cgi?id=211264
> >
> > So this is a regression from that change.
>
> Could you upload the crash trace of this? If non main thread is touching
> `const AtomString` generated by `MainThreadNeverDestroyed<>`, this
> potentially means that `MainThreadNeverDestroyed<>` finds the real bug.
OK, found that, thanks :)
Yusuke Suzuki
(In reply to Yusuke Suzuki from comment #3)
> (In reply to Yusuke Suzuki from comment #2)
> > (In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
> > > Ah, that's a MainThreadNeverDestroyed, introduced by:
> > >
> > > https://bugs.webkit.org/show_bug.cgi?id=211264
> > >
> > > So this is a regression from that change.
> >
> > Could you upload the crash trace of this? If non main thread is touching
> > `const AtomString` generated by `MainThreadNeverDestroyed<>`, this
> > potentially means that `MainThreadNeverDestroyed<>` finds the real bug.
>
> OK, found that, thanks :)
Looks like that patch (adding new assertions) found a GTK specific bug, which cannot be caught due to lack of GTK Debug EWS.
Emilio Cobos Álvarez (:emilio)
Yes, sorry, but I pasted comment 1 in the wrong bug, should've been in bug 211355, that's why I tagged it as off-topic.
Yusuke Suzuki
(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)
> Yes, sorry, but I pasted comment 1 in the wrong bug, should've been in bug
> 211355, that's why I tagged it as off-topic.
np! Thanks for reporting :D
Tyler Wilcock
rdar://96305580
Rune Lillesveen
Given the resolution in [1], this issue is most likely a Wontfix?
[1] https://github.com/w3c/csswg-drafts/issues/3257#issuecomment-1204146452