Bug 211277

Summary: [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: Tools / TestsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Lauro Moura
Reported 2020-04-30 20:53:47 PDT
Currently flatpakutils.py hardcodes the path to the document portal to /run/user/$UID/doc, but in practice, it depends on the value of $XDG_RUNTIME_DIR (which typically is /run/user/$UID). Problems with this var can lead to bubblewrap (used by flatpak) to fail with messages like 'brwap: Can't find source path : No such file or directory.'
Attachments
Patch (2.86 KB, patch)
2020-04-30 21:06 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-04-30 21:06:14 PDT
Created attachment 398156 [details] Patch This version checks environment for XDG_RUNTIME_DIR instead of using the dbus method GetMountPoint. Currently there is no direct dbus usage from webkitpy. One issue that may still be present is the complete absence of the runtime directory. Should flatpakutils.py create a 'fake' one or this should be in charge of whoever uses webkit-flatpak? (e.g. the bots scripts).
EWS
Comment 2 2020-05-01 02:48:26 PDT
Committed r260991: <https://trac.webkit.org/changeset/260991> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398156 [details].
Radar WebKit Bug Importer
Comment 3 2020-05-01 02:49:16 PDT
<rdar://problem/62714503>
Note You need to log in before you can comment on or make changes to this bug.