Bug 211271

Summary: [CSS Easing 1] implement `jump-*` step positions
Product: WebKit Reporter: Devin Rousso <hi>
Component: CSSAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, esprehn+autocc, ews-watchlist, glenn, graouts, graouts, gyuyoung.kim, hi, koivisto, macpherson, menard, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2020-04-30 18:28:20 PDT
<https://drafts.csswg.org/css-easing-1/#step-position> - `jump-start` - `jump-end` - `jump-both` - `jump-none`
Attachments
Patch (44.42 KB, patch)
2020-04-30 18:36 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (54.87 KB, patch)
2020-04-30 22:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (55.95 KB, patch)
2020-05-01 15:23 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-04-30 18:36:58 PDT
Created attachment 398133 [details] Patch
Devin Rousso
Comment 2 2020-04-30 22:39:58 PDT
Created attachment 398161 [details] Patch
Devin Rousso
Comment 3 2020-04-30 22:41:56 PDT
Comment on attachment 398161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398161&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:1578 > + case CSSValueStepStart: I do find it a little odd that `step-start` and `step-end` _must_ be serialized into their equivalent `steps()` value, but that's what the spec says to do ¯\_(ツ)_/¯ <https://drafts.csswg.org/css-easing-1/#serialization>
Dean Jackson
Comment 4 2020-05-01 13:28:14 PDT
Comment on attachment 398161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398161&action=review > Source/WebCore/ChangeLog:7 > + Could you describe here what you actually did? e.g. link to the spec and this video https://www.youtube.com/watch?v=4NO-h9PFum4
Devin Rousso
Comment 5 2020-05-01 15:23:59 PDT
Created attachment 398251 [details] Patch
EWS
Comment 6 2020-05-02 02:34:35 PDT
Committed r261046: <https://trac.webkit.org/changeset/261046> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398251 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-02 02:35:34 PDT
<rdar://problem/62764059>
Antoine Quint
Comment 8 2023-05-10 12:48:33 PDT
*** Bug 190406 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.