Bug 211271 - [CSS Easing 1] implement `jump-*` step positions
Summary: [CSS Easing 1] implement `jump-*` step positions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar, WebExposed, WPTImpact
: 190406 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-30 18:28 PDT by Devin Rousso
Modified: 2023-05-10 12:48 PDT (History)
14 users (show)

See Also:

Attachments
Patch (44.42 KB, patch)
2020-04-30 18:36 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (54.87 KB, patch)
2020-04-30 22:39 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (55.95 KB, patch)
2020-05-01 15:23 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-04-30 18:28:20 PDT 
<https://drafts.csswg.org/css-easing-1/#step-position>
 - `jump-start`
 - `jump-end`
 - `jump-both`
 - `jump-none`
Comment 1 Devin Rousso 2020-04-30 18:36:58 PDT 
Created attachment 398133 [details]
Patch
Comment 2 Devin Rousso 2020-04-30 22:39:58 PDT 
Created attachment 398161 [details]
Patch
Comment 3 Devin Rousso 2020-04-30 22:41:56 PDT 
Comment on attachment 398161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398161&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1578
> +    case CSSValueStepStart:

I do find it a little odd that `step-start` and `step-end` _must_ be serialized into their equivalent `steps()` value, but that's what the spec says to do ¯\_(ツ)_/¯

<https://drafts.csswg.org/css-easing-1/#serialization>
Comment 4 Dean Jackson 2020-05-01 13:28:14 PDT 
Comment on attachment 398161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398161&action=review

> Source/WebCore/ChangeLog:7
> +

Could you describe here what you actually did? e.g. link to the spec

and this video https://www.youtube.com/watch?v=4NO-h9PFum4
Comment 5 Devin Rousso 2020-05-01 15:23:59 PDT 
Created attachment 398251 [details]
Patch
Comment 6 EWS 2020-05-02 02:34:35 PDT 
Committed r261046: <https://trac.webkit.org/changeset/261046>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398251 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-02 02:35:34 PDT 
<rdar://problem/62764059>
Comment 8 Antoine Quint 2023-05-10 12:48:33 PDT 
*** Bug 190406 has been marked as a duplicate of this bug. ***