Bug 211250

Summary:

Inline reportBlockedPortFailed and reportAuthenticationChallengeBlocked

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

New Bugs

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, ews-watchlist, japhet, mkwst, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Rob Buis 2020-04-30 13:11:32 PDT

These two static methods have only one caller each, so we can just
inline them at the call site since there is nothing tying them to FrameLoader.

Comment 1 Rob Buis 2020-04-30 13:13:03 PDT

Created attachment 398085 [details]
Patch

Comment 2 Rob Buis 2020-04-30 14:25:32 PDT

Comment on attachment 398085 [details]
Patch

Note that other solutions are possible as well, like making these private methods in the caller classes, or finding a different place as free functions, I just do not see the relation to FrameLoader.

Comment 3 EWS 2020-04-30 23:50:59 PDT

Committed r260985: <https://trac.webkit.org/changeset/260985>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398085 [details].

Comment 4 Radar WebKit Bug Importer 2020-04-30 23:51:14 PDT

<rdar://problem/62707204>