Bug 211250

Summary: Inline reportBlockedPortFailed and reportAuthenticationChallengeBlocked
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, ews-watchlist, japhet, mkwst, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-04-30 13:11:32 PDT
These two static methods have only one caller each, so we can just inline them at the call site since there is nothing tying them to FrameLoader.
Attachments
Patch (5.07 KB, patch)
2020-04-30 13:13 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-04-30 13:13:03 PDT
Created attachment 398085 [details] Patch
Rob Buis
Comment 2 2020-04-30 14:25:32 PDT
Comment on attachment 398085 [details] Patch Note that other solutions are possible as well, like making these private methods in the caller classes, or finding a different place as free functions, I just do not see the relation to FrameLoader.
EWS
Comment 3 2020-04-30 23:50:59 PDT
Committed r260985: <https://trac.webkit.org/changeset/260985> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398085 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-30 23:51:14 PDT
<rdar://problem/62707204>
Note You need to log in before you can comment on or make changes to this bug.