Bug 211248

Summary: results.webkit.org: Dropped connections when uploading archives shouldn't be fatal
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2020-04-30 12:25:22 PDT
Result archives for layout tests can be unreasonably large, especially if there are many crashes. Failing to upload these archives should not be fatal.
Attachments
Patch (1.56 KB, patch)
2020-04-30 12:28 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2020-04-30 12:37 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.77 KB, patch)
2020-04-30 20:08 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.97 KB, patch)
2020-05-01 07:46 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-04-30 12:28:26 PDT
Created attachment 398081 [details] Patch
Jonathan Bedard
Comment 3 2020-04-30 12:37:42 PDT
Created attachment 398083 [details] Patch
Aakash Jain
Comment 4 2020-04-30 13:20:41 PDT
Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review > Tools/Scripts/webkitpy/results/upload.py:229 > + log_line_func(' ' * 4 + 'Failed to upload test archive to {}, results server dropped connection, likely due to archive size.'.format(hostname)) Can we also print the archive size here? > Tools/Scripts/webkitpy/results/upload.py:231 > + return True What happens is server is down or unreachable? Do we still use this code path or print a different error?
Jonathan Bedard
Comment 5 2020-04-30 14:03:14 PDT
Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review >> Tools/Scripts/webkitpy/results/upload.py:231 >> + return True > > What happens is server is down or unreachable? Do we still use this code path or print a different error? It does, but it’s unlikely we would ever get into that circumstance because the result upload would have also failed.
Jonathan Bedard
Comment 6 2020-04-30 14:03:15 PDT
Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review >> Tools/Scripts/webkitpy/results/upload.py:231 >> + return True > > What happens is server is down or unreachable? Do we still use this code path or print a different error? It does, but it’s unlikely we would ever get into that circumstance because the result upload would have also failed.
Jonathan Bedard
Comment 7 2020-04-30 20:08:48 PDT
Created attachment 398150 [details] Patch
Jonathan Bedard
Comment 8 2020-05-01 07:46:27 PDT
Created attachment 398185 [details] Patch
EWS
Comment 9 2020-05-01 08:34:37 PDT
Committed r261000: <https://trac.webkit.org/changeset/261000> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398185 [details].
Radar WebKit Bug Importer
Comment 10 2020-05-01 08:35:15 PDT
<rdar://problem/62728138>
Note You need to log in before you can comment on or make changes to this bug.