Bug 211136

Summary: Move WebPage::textInputContextsInRect() to WebPageIOS.mm
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211135
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
To Land none

Daniel Bates
Reported 2020-04-28 11:31:46 PDT
WebPage::textInputContextsInRect() is only used on iOS at the moment and likely is not relevant to any other port. So, move it to WebPageIOS.mm.
Attachments
Patch (6.52 KB, patch)
2020-04-28 11:53 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (9.88 KB, patch)
2020-04-28 16:31 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (9.88 KB, patch)
2020-04-28 16:31 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (9.90 KB, patch)
2020-04-28 17:05 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-04-28 11:53:24 PDT
Created attachment 397862 [details] Patch
Daniel Bates
Comment 2 2020-04-28 11:54:44 PDT
I wrote this patch on top of the patch for bug #211135. So, it won't apply until that one lands.
Daniel Bates
Comment 3 2020-04-28 16:31:08 PDT
Created attachment 397898 [details] Patch
Daniel Bates
Comment 4 2020-04-28 16:31:50 PDT
Created attachment 397899 [details] Patch
Daniel Bates
Comment 5 2020-04-28 17:01:48 PDT
Comment on attachment 397899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397899&action=review > Source/WebKit/ChangeLog:18 > + I side effect of this change is that I also move WebPageProxy::textInputContextsInRect() I => A
Eric Carlson
Comment 6 2020-04-28 17:02:42 PDT
Comment on attachment 397899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397899&action=review > Source/WebKit/ChangeLog:18 > + I side effect of this change is that I also move WebPageProxy::textInputContextsInRect() s/I side effect/A side effect/ (or do you mean "One side effect"?)
Daniel Bates
Comment 7 2020-04-28 17:05:42 PDT
Created attachment 397909 [details] To Land
Daniel Bates
Comment 8 2020-04-28 17:06:04 PDT
Committed r260857: <https://trac.webkit.org/changeset/260857>
Radar WebKit Bug Importer
Comment 9 2020-04-28 17:11:11 PDT
<rdar://problem/62558562>
Note You need to log in before you can comment on or make changes to this bug.