| Summary: | Move WebPage::textInputContextsInRect() to WebPageIOS.mm | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric.carlson, simon.fraser, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=211135 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Daniel Bates
2020-04-28 11:31:46 PDT
Created attachment 397862 [details]
Patch
I wrote this patch on top of the patch for bug #211135. So, it won't apply until that one lands. Created attachment 397898 [details]
Patch
Created attachment 397899 [details]
Patch
Comment on attachment 397899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397899&action=review > Source/WebKit/ChangeLog:18 > + I side effect of this change is that I also move WebPageProxy::textInputContextsInRect() I => A Comment on attachment 397899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397899&action=review > Source/WebKit/ChangeLog:18 > + I side effect of this change is that I also move WebPageProxy::textInputContextsInRect() s/I side effect/A side effect/ (or do you mean "One side effect"?) Created attachment 397909 [details]
To Land
Committed r260857: <https://trac.webkit.org/changeset/260857> |