| Summary: | REGRESSION(r260822): Broke media/track/track-in-band-metadata-display-order.html on Mac | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | WebKit2 | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, Lawrence.j, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210976 | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2020-04-28 09:40:44 PDT
Created attachment 397847 [details]
Patch
*** Bug 211132 has been marked as a duplicate of this bug. *** history: https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack-in-band-metadata-display-order.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-in-band-metadata-display-order-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-in-band-metadata-display-order-actual.txt @@ -15,7 +15,7 @@ RUN(metadataTrack.addCue(new DataCue(2.25, video.duration, "second data cue"))) RUN(video.currentTime = 3) EVENT(seeked) -EXPECTED (textTrackDisplayElement(video, "display", 0).textContent == 'I am later') OK -EXPECTED (textTrackDisplayElement(video, "display", 1).textContent == 'I am earlier') OK +EXPECTED (textTrackDisplayElement(video, "display", 0).textContent == 'I am later'), OBSERVED 'I am later ::cue{background-color:rgba(0, 0, 0, 0) !important;color:#ffffff;font-family: "Helvetica";} ::-webkit-media-text-track-display-backdrop{background-color:rgba(0, 0, 0, 0.498) !important;padding: .4em !important;border-radius:8px !important;}' FAIL +EXPECTED (textTrackDisplayElement(video, "display", 1).textContent == 'I am earlier'), OBSERVED 'I am earlier ::cue{background-color:rgba(0, 0, 0, 0) !important;color:#ffffff;font-family: "Helvetica";} ::-webkit-media-text-track-display-backdrop{background-color:rgba(0, 0, 0, 0.498) !important;padding: .4em !important;border-radius:8px !important;}' FAIL END OF TEST [tag] [reply] [−] Comment 7 Apololgies for not noticing this, because in GTK we had that test flagged already as failing/crash/pass ... See #198830 Comment on attachment 397847 [details]
Patch
Forgot to rebaseline.
Created attachment 397856 [details]
Patch
I unflagged the test on GTK and checked it passes. Can't check on mac currently though. Committed r260835: <https://trac.webkit.org/changeset/260835> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397856 [details]. |