Bug 21113 – r36771 caused www.nytimes.com to not display when you return to it using back/forward

• Component: CSS
• Status: RESOLVED FIXED

[Brady Eidson]

r36771 caused www.nytimes.com to not display when you return to it using back/forward.

Since this was primarily a "cleanup patch", I rolled it out in r36902 as this was a pretty severe regression (important site).  

Steps to reproduce with 36771 in place:

1 - Visit www.google.com, let it finish loading
2 - Visit www.nytimes.com, let it finish loading
3 - Click "back" to return to google.com
4 - Click "forward" to return to nytimes.com

After step 4, nytimes.com is blank.  All of the resources are there and loaded, and Cmd-R to forcefully refresh the page causes it to actually render, but whenever you return to it through back or forward, it is always blank.

[Dave Hyatt]

Created attachment 23817 [details]
Patch #2

[Darin Adler]

Comment on attachment 23817 [details]
Patch #2

 CSSRule* CSSRule::parentRule() const
 {
-    // FIXME: I believe this always returns 0.
-    // A correct implementation would have to look farther up than just the parent.
     return (parent() && parent()->isRule()) ? static_cast<CSSRule*>(parent()) : 0;
 }

Why is this comment wrong. Isn't the parent almost always a style sheet, and not a rule?

r=me

[Dave Hyatt]

Fixed in r36904.

[Dave Hyatt]

*** Bug 21119 has been marked as a duplicate of this bug. ***

[Matt Lilek]

*** Bug 21125 has been marked as a duplicate of this bug. ***