Bug 21109

Summary:

Console should right-align urls

Product:

WebKit

Reporter:

Kevin McCullough <kmccullough>

Component:

Web Inspector (Deprecated)

Assignee:

Kevin McCullough <kmccullough>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	none
Image of what right-align looks like	none
and what it looks like docked	none
docked without arrow	none
no arrow 1/2 padding	none
no arrow 10px padding	none
Proposed patch	none
Proposed patch	timothy: review+

Kevin McCullough

Reported 2008-09-25 10:13:19 PDT

* SUMMARY In the console if a JS error or JS log occurs the furthest right part of the message is a link to the resource with the error (often with the line number). It would be nice if those were right-alinged (like Firebug) so they could be more easily seen. <rdar://problem/6126184>

Attachments
Proposed patch (872 bytes, patch) 2008-09-25 10:14 PDT, Kevin McCullough	no flags	Details Formatted Diff Diff
Image of what right-align looks like (19.25 KB, image/png) 2008-09-25 10:19 PDT, Kevin McCullough	no flags	Details
and what it looks like docked (20.28 KB, image/png) 2008-09-25 10:19 PDT, Kevin McCullough	no flags	Details
docked without arrow (21.02 KB, image/png) 2008-09-25 10:22 PDT, Kevin McCullough	no flags	Details
no arrow 1/2 padding (16.68 KB, image/png) 2008-09-25 10:26 PDT, Kevin McCullough	no flags	Details
no arrow 10px padding (18.49 KB, image/png) 2008-09-25 10:28 PDT, Kevin McCullough	no flags	Details
Proposed patch (1.57 KB, patch) 2008-09-25 10:32 PDT, Kevin McCullough	no flags	Details Formatted Diff Diff
Proposed patch (3.55 KB, patch) 2008-09-25 11:31 PDT, Kevin McCullough	timothy: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Kevin McCullough

Comment 1 2008-09-25 10:14:44 PDT

Created attachment 23802 [details] Proposed patch

Kevin McCullough

Comment 2 2008-09-25 10:19:10 PDT

Created attachment 23803 [details] Image of what right-align looks like

Kevin McCullough

Comment 3 2008-09-25 10:19:53 PDT

Created attachment 23804 [details] and what it looks like docked

Kevin McCullough

Comment 4 2008-09-25 10:22:26 PDT

Created attachment 23805 [details] docked without arrow

Kevin McCullough

Comment 5 2008-09-25 10:26:28 PDT

Created attachment 23806 [details] no arrow 1/2 padding

Kevin McCullough

Comment 6 2008-09-25 10:28:45 PDT

Created attachment 23807 [details] no arrow 10px padding

Kevin McCullough

Comment 7 2008-09-25 10:32:14 PDT

Created attachment 23808 [details] Proposed patch

Kevin McCullough

Comment 8 2008-09-25 10:34:52 PDT

I need to change the DOM order. If a message wraps the url ends up on the same line as the next message.

Kevin McCullough

Comment 9 2008-09-25 11:31:49 PDT

Created attachment 23810 [details] Proposed patch

Kevin McCullough

Comment 10 2008-09-25 13:30:11 PDT

Committed revision 36905.

Note You need to log in before you can comment on or make changes to this bug.