Bug 211056

Summary: Text interaction tests should ensure view is not scroll instead of looking for a zoom change
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210939
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2020-04-26 16:06:42 PDT
Currently the text interaction tests in RequestTextInputContext.mm look for a zoom scale change as an indirect way to know whether or not the web view zoomed to reveal the focused element. However the way the tests do so by changing the zoom scale without ensuring the editable element is still semi-occluded is racy. It works out so long as the call to focus the editable element (aka -focusTextInputContext) is processed by the web process BEFORE it receives a visible content rect update (as a result of the zoomScale change). Instead write these tests to check if the scroll view actually scrolled or not.
Attachments
Patch (14.51 KB, patch)
2020-04-26 16:23 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-04-26 16:23:58 PDT
Created attachment 397632 [details] Patch
Daniel Bates
Comment 2 2020-04-27 08:44:29 PDT
Comment on attachment 397632 [details] Patch Clearing flags on attachment: 397632 Committed r260756: <https://trac.webkit.org/changeset/260756>
Daniel Bates
Comment 3 2020-04-27 08:44:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-04-27 08:45:18 PDT
<rdar://problem/62453615>
Note You need to log in before you can comment on or make changes to this bug.