Bug 211053

Summary: [JSC] Clearly distinguish isConstructor from getConstructData
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211037
https://bugs.webkit.org/show_bug.cgi?id=211059
Attachments:
Description Flags
Patch
none
Patch none

Ross Kirsling
Reported 2020-04-26 14:01:05 PDT
[JSC] Clearly distinguish isConstructor from getConstructData
Attachments
Patch (6.98 KB, patch)
2020-04-26 14:05 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (6.98 KB, patch)
2020-04-26 14:15 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-04-26 14:05:48 PDT
Created attachment 397629 [details] Patch
Ross Kirsling
Comment 2 2020-04-26 14:11:01 PDT
I suppose with the usages clearly distinguished, Darin's suggestion of merging CallType/ConstructType into CallData/ConstructData would be a reasonable further improvement. I can do this in a third patch if others like the idea too.
Ross Kirsling
Comment 3 2020-04-26 14:15:07 PDT
Created attachment 397630 [details] Patch
EWS
Comment 4 2020-04-26 17:37:19 PDT
Committed r260735: <https://trac.webkit.org/changeset/260735> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397630 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-26 17:38:14 PDT
<rdar://problem/62415782>
Note You need to log in before you can comment on or make changes to this bug.