| Summary: | [Cocoa] stop using out arguments for document attributes when converting to attributed strings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | HTML Editing | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, bfulgham, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, jer.noble, mifenton, philipj, sam, sergio, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2020-04-26 11:19:26 PDT
Created attachment 397623 [details]
Patch
Started this in response to Sam’s review comment in bug 210396. Created attachment 397626 [details]
Patch
Comment on attachment 397626 [details]
Patch
!!
Committed r260739: <https://trac.webkit.org/changeset/260739> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397626 [details]. I believe this change is incomplete for MacCatalyst builds. See UIProcess/Cocoa/TextCheckingController.mm. (In reply to Brent Fulgham from comment #7) > I believe this change is incomplete for MacCatalyst builds. See > UIProcess/Cocoa/TextCheckingController.mm. Tried to fix this in r260766 That was almost perfect! I had to add a couple of #include's because of the vagaries of UnifiedSources. Committed r260768: <https://trac.webkit.org/changeset/260768> (In reply to EWS from comment #5) > Committed r260739: <https://trac.webkit.org/changeset/260739> Catalina Perf tests started failing due to some unexpected logging after this change: https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Perf/builds/783 Partial revert (as suggested by Darin) in https://trac.webkit.org/changeset/260785/webkit |