Bug 211048

Summary: [Cocoa] stop using out arguments for document attributes when converting to attributed strings
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, jer.noble, mifenton, philipj, sam, sergio, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2020-04-26 11:19:26 PDT
[Cocoa] stop using out arguments for document attributes when converting to attributed strings
Attachments
Patch (75.41 KB, patch)
2020-04-26 11:36 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (75.78 KB, patch)
2020-04-26 12:27 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-04-26 11:36:03 PDT
Created attachment 397623 [details] Patch
Darin Adler
Comment 2 2020-04-26 11:36:56 PDT
Started this in response to Sam’s review comment in bug 210396.
Darin Adler
Comment 3 2020-04-26 12:27:35 PDT
Created attachment 397626 [details] Patch
Sam Weinig
Comment 4 2020-04-26 18:08:42 PDT
Comment on attachment 397626 [details] Patch !!
EWS
Comment 5 2020-04-26 22:13:00 PDT
Committed r260739: <https://trac.webkit.org/changeset/260739> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397626 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-26 22:13:17 PDT
<rdar://problem/62426218>
Brent Fulgham
Comment 7 2020-04-27 10:48:34 PDT
I believe this change is incomplete for MacCatalyst builds. See UIProcess/Cocoa/TextCheckingController.mm.
Darin Adler
Comment 8 2020-04-27 10:56:18 PDT
(In reply to Brent Fulgham from comment #7) > I believe this change is incomplete for MacCatalyst builds. See > UIProcess/Cocoa/TextCheckingController.mm. Tried to fix this in r260766
Brent Fulgham
Comment 9 2020-04-27 11:17:29 PDT
That was almost perfect! I had to add a couple of #include's because of the vagaries of UnifiedSources. Committed r260768: <https://trac.webkit.org/changeset/260768>
Ryan Haddad
Comment 10 2020-04-27 14:35:23 PDT
(In reply to EWS from comment #5) > Committed r260739: <https://trac.webkit.org/changeset/260739> Catalina Perf tests started failing due to some unexpected logging after this change: https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Perf/builds/783 Partial revert (as suggested by Darin) in https://trac.webkit.org/changeset/260785/webkit
Note You need to log in before you can comment on or make changes to this bug.