Bug 211028

Summary:

[Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	eric.carlson: review+
Patch for landing	none
Patch for landing	none
Patch for landing	none
Follow up fix	none

Jer Noble

Reported 2020-04-25 13:48:33 PDT

[Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification

Attachments
Patch (50.81 KB, patch) 2020-04-25 13:52 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (54.68 KB, patch) 2020-04-27 11:31 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (54.70 KB, patch) 2020-04-27 11:43 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (54.72 KB, patch) 2020-04-27 13:23 PDT, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
Patch for landing (54.60 KB, patch) 2020-04-27 14:24 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (54.85 KB, patch) 2020-04-27 21:13 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (54.61 KB, patch) 2020-04-27 21:46 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Follow up fix (2.02 KB, patch) 2020-04-29 09:55 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2020-04-25 13:51:39 PDT

<rdar://problem/61173289>

Jer Noble

Comment 2 2020-04-25 13:52:15 PDT

Created attachment 397580 [details] Patch

Jer Noble

Comment 3 2020-04-27 11:31:23 PDT

Created attachment 397704 [details] Patch

Jer Noble

Comment 4 2020-04-27 11:43:58 PDT

Created attachment 397705 [details] Patch

Jer Noble

Comment 5 2020-04-27 13:23:04 PDT

Created attachment 397727 [details] Patch

Eric Carlson

Comment 6 2020-04-27 13:29:24 PDT

Comment on attachment 397727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397727&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:1127 > + registerHighDynamicRangeChangeCallback(); Nit: why not put this in the `#if !PLATFORM(MAC)` above rather than adding an empty `registerHighDynamicRangeChangeCallback` method to every port?

Jer Noble

Comment 7 2020-04-27 13:45:18 PDT

(In reply to Eric Carlson from comment #6) > Comment on attachment 397727 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397727&action=review > > > Source/WebKit/UIProcess/WebProcessPool.cpp:1127 > > + registerHighDynamicRangeChangeCallback(); > > Nit: why not put this in the `#if !PLATFORM(MAC)` above rather than adding > an empty `registerHighDynamicRangeChangeCallback` method to every port? Because I have been vigorously instructed to avoid platform-specific code in non-platform specific classes.

Jer Noble

Comment 8 2020-04-27 14:24:49 PDT

Created attachment 397737 [details] Patch for landing

Jer Noble

Comment 9 2020-04-27 21:13:42 PDT

Created attachment 397797 [details] Patch for landing

Jer Noble

Comment 10 2020-04-27 21:46:38 PDT

Created attachment 397803 [details] Patch for landing

EWS

Comment 11 2020-04-28 10:04:32 PDT

Committed r260832: <https://trac.webkit.org/changeset/260832> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397803 [details].

Aakash Jain

Comment 12 2020-04-29 04:17:03 PDT

> Committed r260832: <https://trac.webkit.org/changeset/260832> This seems to have broken 7 layout-tests on windows, as also warned by EWS. Results database also points to this commit: https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fbeforeload%2Fvideo-before-load.html&platform=win

Jer Noble

Comment 13 2020-04-29 09:55:05 PDT

Reopening to attach new patch.

Jer Noble

Comment 14 2020-04-29 09:55:06 PDT

Created attachment 397972 [details] Follow up fix

EWS

Comment 15 2020-04-29 11:53:49 PDT

Committed r260907: <https://trac.webkit.org/changeset/260907> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397972 [details].

Note You need to log in before you can comment on or make changes to this bug.