Bug 211012

Summary: Suppress ASan on DFG::clobberize() to work around an ASan bug.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, ggaren, keith_miller, msaboff, pgyanchandani, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2020-04-24 23:20:17 PDT
ASan was incorrectly thinking that we're accessing invalid stack memory when we're not. <rdar://problem/62275430>
Attachments
proposed patch. (3.60 KB, patch)
2020-04-24 23:46 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-04-24 23:46:19 PDT
Created attachment 397545 [details] proposed patch.
Yusuke Suzuki
Comment 2 2020-04-24 23:59:35 PDT
Comment on attachment 397545 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=397545&action=review r=me > Source/JavaScriptCore/dfg/DFGClobberize.h:43 > +SUPPRESS_ASAN void clobberize(Graph& graph, Node* node, const ReadFunctor& read, const WriteFunctor& write, const DefFunctor& def) Can you add FIXME comment describing why SUPPRESS_ASAN is necessary (describing about ASAN bug)?
Mark Lam
Comment 3 2020-04-25 00:25:18 PDT
(In reply to Yusuke Suzuki from comment #2) > Can you add FIXME comment describing why SUPPRESS_ASAN is necessary > (describing about ASAN bug)? Thanks for the review. I've added the FIXME with explanation. Landed in r260692: <http://trac.webkit.org/r260692>.
Note You need to log in before you can comment on or make changes to this bug.