Bug 210999

Summary: Add some debug output for run-jsc-stress-tests
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: New BugsAssignee: Zhifei Fang <zhifei_fang>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, saam, tsavell, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Zhifei Fang
Reported 2020-04-24 15:28:44 PDT
Add some debug output for run-jsc-stress-tests
Attachments
Patch (1.66 KB, patch)
2020-04-24 15:29 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2020-04-24 15:51 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (1.80 KB, patch)
2020-04-27 14:14 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zhifei Fang
Comment 1 2020-04-24 15:29:15 PDT
Created attachment 397518 [details] Patch
Zhifei Fang
Comment 2 2020-04-24 15:29:55 PDT
I am using this to trigger a EWS to see where we hit for the JSC time out issue
Zhifei Fang
Comment 3 2020-04-24 15:33:16 PDT
Most the timeout happened at the end of the running, it could be timeout in the detect failure stage, add these output to help me locate where are the timeout
Jonathan Bedard
Comment 4 2020-04-24 15:49:18 PDT
Comment on attachment 397518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397518&action=review > Tools/ChangeLog:3 > + Add some debug output for run-jsc-stress-tests Can we embed some of the why in the commit message?
Zhifei Fang
Comment 5 2020-04-24 15:51:40 PDT
Created attachment 397522 [details] Patch
Zhifei Fang
Comment 6 2020-04-24 15:52:18 PDT
(In reply to Jonathan Bedard from comment #4) > Comment on attachment 397518 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397518&action=review > > > Tools/ChangeLog:3 > > + Add some debug output for run-jsc-stress-tests > > Can we embed some of the why in the commit message? Added the radar link as well
Zhifei Fang
Comment 7 2020-04-27 14:14:12 PDT
Created attachment 397736 [details] Patch
EWS
Comment 8 2020-04-27 14:38:03 PDT
Committed r260786: <https://trac.webkit.org/changeset/260786> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397736 [details].
Radar WebKit Bug Importer
Comment 9 2020-04-27 14:39:14 PDT
<rdar://problem/62469359>
Saam Barati
Comment 10 2020-04-27 18:34:27 PDT
Comment on attachment 397736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397736&action=review This should be behind an option, not the default. This prints each time you run it and it makes it seems like it might have failed. > Tools/Scripts/run-jsc-stress-tests:2165 > + puts "Detacted failures in #{Time.now - start_time}" typo: Detacted => Detected
Note You need to log in before you can comment on or make changes to this bug.