Bug 210998

Summary: OSR Exit compiler should know and print the exiting DFG node's index
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, Lawrence.j, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2020-04-24 15:22:05 PDT
OSR Exit compiler should know and print the exiting DFG node's index
Attachments
Patch (11.81 KB, patch)
2020-04-24 15:22 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (11.98 KB, patch)
2020-04-24 15:23 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.51 KB, patch)
2020-04-27 12:51 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-04-24 15:22:28 PDT
Created attachment 397516 [details] Patch
Keith Miller
Comment 2 2020-04-24 15:23:50 PDT
Created attachment 397517 [details] Patch
Mark Lam
Comment 3 2020-04-24 15:31:02 PDT
Comment on attachment 397517 [details] Patch r=me if you’ve verified that there’s no size increase.
Keith Miller
Comment 4 2020-04-24 16:04:42 PDT
$ ./Tools/Scripts/dump-class-layout JavaScriptCore DFG::OSRExitBase -c Debug +0 < 32> JSC::DFG::OSRExitBase +0 < 4> uint32_t m_count +4 < 1> JSC::ExitKind m_kind +5 < :1> bool m_wasHoisted : 1 +5 < :23> uint32_t m_dfgNodeIndex : 23 +8 < 8> JSC::CodeOrigin m_codeOrigin +8 < 8> uintptr_t m_compositeValue +16 < 8> JSC::CodeOrigin m_codeOriginForExitProfile +16 < 8> uintptr_t m_compositeValue +24 < 4> JSC::CallSiteIndex m_exceptionHandlerCallSiteIndex +24 < 4> uint32_t m_bits +28 < 4> <PADDING: 4 bytes> Total byte size: 32 Total pad bytes: 4 Padding percentage: 12.50 %
Keith Miller
Comment 5 2020-04-27 12:51:20 PDT
Created attachment 397721 [details] Patch for landing
EWS
Comment 6 2020-04-27 13:22:36 PDT
Committed r260772: <https://trac.webkit.org/changeset/260772> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397721 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-27 13:23:20 PDT
<rdar://problem/62465824>
Jason Lawrence
Comment 8 2020-04-27 17:16:56 PDT
Reverted r260772 for reason: This commit caused tests to start failing internally. Committed r260799: <https://trac.webkit.org/changeset/260799>
Keith Miller
Comment 9 2020-04-27 17:51:58 PDT
Committed r260803: <https://trac.webkit.org/changeset/260803>
Note You need to log in before you can comment on or make changes to this bug.