Bug 210988 – [Web Animations] Ensure calling Web Animations APIs override future CSS Animations style properties

• Component: Animations
• Status: RESOLVED FIXED

[Antoine Quint]

[Web Animations] Ensure calling Web Animations APIs override future CSS Animations style properties

[Antoine Quint]

Created attachment 397495 [details]
Patch

[Dean Jackson]

Comment on attachment 397495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397495&action=review

> Source/WebCore/animation/WebAnimation.cpp:151
> +void WebAnimation::setBindingsEffect(RefPtr<AnimationEffect>&& newEffect)
> +{
> +    setEffect(WTFMove(newEffect));
> +}

Why does this need a different name for bindings? And the other two below.

[Antoine Quint]

(In reply to Dean Jackson from comment #2)
> Comment on attachment 397495 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397495&action=review
> 
> > Source/WebCore/animation/WebAnimation.cpp:151
> > +void WebAnimation::setBindingsEffect(RefPtr<AnimationEffect>&& newEffect)
> > +{
> > +    setEffect(WTFMove(newEffect));
> > +}
> 
> Why does this need a different name for bindings? And the other two below.

Because CSSAnimation subclasses this method to apply some overrides. This needs to happen only when the effect is set via the JS API.

[Antoine Quint]

Committed r260671: <https://trac.webkit.org/changeset/260671>

[Radar WebKit Bug Importer]

<rdar://problem/62340827>