| Summary: | Disable useKernTCSM=false for JSC stress tests to make EWS faster | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, mark.lam, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=199117 | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-04-23 18:03:39 PDT
Created attachment 397410 [details]
Patch
Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review > Tools/Scripts/run-javascriptcore-tests:-532 > -} I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. EWS JSC stress bot finishes with 59:23, so this patch is effective. Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review >> Tools/Scripts/run-javascriptcore-tests:-532 >> -} > > I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. I've ensured this works on EWS. Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review r=me >>> Tools/Scripts/run-javascriptcore-tests:-532 >>> -} >> >> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. > > I've ensured this works on EWS. Jonathan Bedard (cc'ed) added this change. I'm fine with removing it since we have evidence that it speeds up the EWS. Committed r260617: <https://trac.webkit.org/changeset/260617> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397410 [details]. Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review >>>> Tools/Scripts/run-javascriptcore-tests:-532 >>>> -} >>> >>> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. >> >> I've ensured this works on EWS. > > Jonathan Bedard (cc'ed) added this change. I'm fine with removing it since we have evidence that it speeds up the EWS. I would agree. I have evidence JSC_useKernTCSM=false speeds up layout tests, but never had evidence for JSC tests. |