Summary: | [iOS] Stop using legacy BKSApplicationStateMonitor | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | achristensen, ggaren, thorton, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | 211651 | ||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2020-04-23 17:38:49 PDT
Created attachment 397404 [details]
Patch
Created attachment 397405 [details]
Patch
Created attachment 397406 [details]
Patch
Created attachment 397407 [details]
Patch
Created attachment 397408 [details]
Patch
Created attachment 397412 [details]
Patch
Created attachment 397414 [details]
Patch
Comment on attachment 397414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397414&action=review > Source/WebKit/Configurations/WebKit.xcconfig:53 > +WK_ASSERTION_SERVICES_LDFLAGS_iphoneos = $(WK_ASSERTION_SERVICES_LDFLAGS_IOS$(WK_IOS_14)); > +WK_ASSERTION_SERVICES_LDFLAGS_iphonesimulator = $(WK_ASSERTION_SERVICES_LDFLAGS_IOS$(WK_IOS_14)); Drop the extra _IOS: WK_ASSERTION_SERVICES_LDFLAGS_iphoneos = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14)); WK_ASSERTION_SERVICES_LDFLAGS_iphonesimulator = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14)); and you should be good. Sorry for the typo! > Source/WebKit/Configurations/WebKit.xcconfig:59 > +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices; At some point we should get some nice target conditional macros for these too > Source/WebKit/Configurations/WebKit.xcconfig:60 > +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices; You can totally use WK_MACOS_whatever for macCatalyst Created attachment 397415 [details]
Patch
Comment on attachment 397415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397415&action=review > Source/WebKit/Configurations/WebKit.xcconfig:55 > +// FIXME: It is unecessary to link against AssertionServices with the latest SDK for the following platforms too. sp: "unecessary" Committed r260642: <https://trac.webkit.org/changeset/260642> |