Bug 210945

Summary: [iOS] Stop using legacy BKSApplicationStateMonitor
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 211651    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch thorton: review+

Chris Dumez
Reported 2020-04-23 17:38:49 PDT
Stop using legacy BKSApplicationStateMonitor and use RunningBoard API instead.
Attachments
Patch (11.03 KB, patch)
2020-04-23 17:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.02 KB, patch)
2020-04-23 17:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.01 KB, patch)
2020-04-23 17:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.09 KB, patch)
2020-04-23 17:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.09 KB, patch)
2020-04-23 17:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.76 KB, patch)
2020-04-23 18:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.75 KB, patch)
2020-04-23 18:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.75 KB, patch)
2020-04-23 19:02 PDT, Chris Dumez 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-04-23 17:41:57 PDT
Created attachment 397404 [details] Patch
Chris Dumez
Comment 2 2020-04-23 17:45:38 PDT
Created attachment 397405 [details] Patch
Chris Dumez
Comment 3 2020-04-23 17:50:35 PDT
Created attachment 397406 [details] Patch
Chris Dumez
Comment 4 2020-04-23 17:53:55 PDT
Created attachment 397407 [details] Patch
Chris Dumez
Comment 5 2020-04-23 17:54:32 PDT
Created attachment 397408 [details] Patch
Chris Dumez
Comment 6 2020-04-23 18:09:27 PDT
Created attachment 397412 [details] Patch
Chris Dumez
Comment 7 2020-04-23 18:41:46 PDT
Created attachment 397414 [details] Patch
Tim Horton
Comment 8 2020-04-23 18:55:09 PDT
Comment on attachment 397414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397414&action=review > Source/WebKit/Configurations/WebKit.xcconfig:53 > +WK_ASSERTION_SERVICES_LDFLAGS_iphoneos = $(WK_ASSERTION_SERVICES_LDFLAGS_IOS$(WK_IOS_14)); > +WK_ASSERTION_SERVICES_LDFLAGS_iphonesimulator = $(WK_ASSERTION_SERVICES_LDFLAGS_IOS$(WK_IOS_14)); Drop the extra _IOS: WK_ASSERTION_SERVICES_LDFLAGS_iphoneos = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14)); WK_ASSERTION_SERVICES_LDFLAGS_iphonesimulator = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14)); and you should be good. Sorry for the typo! > Source/WebKit/Configurations/WebKit.xcconfig:59 > +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices; > +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices; At some point we should get some nice target conditional macros for these too > Source/WebKit/Configurations/WebKit.xcconfig:60 > +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices; You can totally use WK_MACOS_whatever for macCatalyst
Chris Dumez
Comment 9 2020-04-23 19:02:29 PDT
Created attachment 397415 [details] Patch
Tim Horton
Comment 10 2020-04-23 22:32:58 PDT
Comment on attachment 397415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397415&action=review > Source/WebKit/Configurations/WebKit.xcconfig:55 > +// FIXME: It is unecessary to link against AssertionServices with the latest SDK for the following platforms too. sp: "unecessary"
Chris Dumez
Comment 11 2020-04-24 07:57:38 PDT
Committed r260642: <https://trac.webkit.org/changeset/260642>
Radar WebKit Bug Importer
Comment 12 2020-04-24 07:58:14 PDT
<rdar://problem/62312842>
Note You need to log in before you can comment on or make changes to this bug.