Bug 210914

Summary: Correction for patch 397001.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andres Gonzalez 2020-04-23 08:26:12 PDT
Correction for patch 397001.
Comment 1 Andres Gonzalez 2020-04-23 08:35:01 PDT
Created attachment 397344 [details]
Patch
Comment 2 EWS 2020-04-23 09:12:09 PDT
Committed r260573: <https://trac.webkit.org/changeset/260573>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397344 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-23 09:13:16 PDT
<rdar://problem/62248776>
Comment 4 Darin Adler 2020-04-23 10:47:58 PDT
Comment on attachment 397344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397344&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2289
> +    AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attributeName));

makeString is more efficient than making two String objects and then calling +; allocates 1 String instead 3

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3872
> +    AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attribute));

Ditto.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4477
> +    AXTRACE(String("WebAccessibilityObjectWrapper accessibilityArrayAttributeValue:") + String(attribute));

Ditto.