Bug 21089

Summary:

Avoid constantly branching on m_table in getOffset

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

JavaScriptCore

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

barraclough

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch for testing - does what I said, not sure if it is a speedup	none

Maciej Stachowiak

Reported 2008-09-24 22:48:26 PDT

Profiles show that getOwnPropertySlot/getOffset spends a lot of time on the initial branch in getOFfset that checks if the table is null. Now that PropertyMap no longer has to fit into a cell, it could keep a table up to a certain limit inline and avoid this null check.

Attachments
patch for testing - does what I said, not sure if it is a speedup (8.66 KB, patch) 2008-09-24 22:49 PDT, Maciej Stachowiak	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2008-09-24 22:49:43 PDT

Created attachment 23779 [details] patch for testing - does what I said, not sure if it is a speedup

Gavin Barraclough

Comment 2 2012-09-07 00:29:30 PDT

This patch will not apply to ToT.

Note You need to log in before you can comment on or make changes to this bug.