Summary: | All ITP database tables should reference the ObservedDomains table on DELETE CASCADE | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||||||
Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | beidson, bfulgham, webkit-bug-importer, wilander | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Kate Cheney
2020-04-22 14:08:17 PDT
Created attachment 397260 [details]
Patch
Created attachment 397295 [details]
Patch
+ test case Comment on attachment 397295 [details]
Patch
This seems reasonable, but every bot is sad.
(In reply to Brady Eidson from comment #5) > Comment on attachment 397295 [details] > Patch > > This seems reasonable, but every bot is sad. Hopefully just needs a rebase Created attachment 397348 [details]
Patch
Created attachment 397376 [details]
Patch
Realized this should call createUniqueIndices() again after creating the new schema (they get deleted when migrating the data). Added this and updated the test case to check for it. Committed r260594: <https://trac.webkit.org/changeset/260594> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397376 [details]. |