Bug 210874

Summary: All ITP database tables should reference the ObservedDomains table on DELETE CASCADE
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Kate Cheney
Reported 2020-04-22 14:08:17 PDT
This will make deleting individual ITP entries from the database very simple.
Attachments
Patch (12.77 KB, patch)
2020-04-22 14:21 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (25.17 KB, patch)
2020-04-22 17:25 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (25.14 KB, patch)
2020-04-23 09:31 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (27.72 KB, patch)
2020-04-23 12:48 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-04-22 14:08:43 PDT
<rdar://problem/62209438>
Kate Cheney
Comment 2 2020-04-22 14:21:22 PDT
Created attachment 397260 [details] Patch
Kate Cheney
Comment 3 2020-04-22 17:25:18 PDT
Created attachment 397295 [details] Patch
Kate Cheney
Comment 4 2020-04-22 17:25:26 PDT
+ test case
Brady Eidson
Comment 5 2020-04-22 19:47:07 PDT
Comment on attachment 397295 [details] Patch This seems reasonable, but every bot is sad.
Kate Cheney
Comment 6 2020-04-23 08:16:53 PDT
(In reply to Brady Eidson from comment #5) > Comment on attachment 397295 [details] > Patch > > This seems reasonable, but every bot is sad. Hopefully just needs a rebase
Kate Cheney
Comment 7 2020-04-23 09:31:26 PDT
Created attachment 397348 [details] Patch
Kate Cheney
Comment 8 2020-04-23 12:48:11 PDT
Created attachment 397376 [details] Patch
Kate Cheney
Comment 9 2020-04-23 12:49:36 PDT
Realized this should call createUniqueIndices() again after creating the new schema (they get deleted when migrating the data). Added this and updated the test case to check for it.
EWS
Comment 10 2020-04-23 13:17:53 PDT
Committed r260594: <https://trac.webkit.org/changeset/260594> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397376 [details].
Note You need to log in before you can comment on or make changes to this bug.