Bug 210858

Summary: getDisplayMedia is not respecting aspect ratio with max constraints
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch none

youenn fablet
Reported 2020-04-22 08:41:50 PDT
getDisplayMedia is not respecting aspect ratio with max constraints
Attachments
Patch (104.79 KB, patch)
2020-04-22 09:35 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (104.78 KB, patch)
2020-04-22 09:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (104.80 KB, patch)
2020-04-22 10:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (105.47 KB, patch)
2020-04-22 10:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (105.54 KB, patch)
2020-04-22 10:34 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (105.43 KB, patch)
2020-04-22 12:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (106.26 KB, patch)
2020-04-23 00:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.76 KB, patch)
2020-04-24 00:51 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-04-22 09:35:30 PDT
Created attachment 397209 [details] Patch
youenn fablet
Comment 2 2020-04-22 09:36:24 PDT
<rdar://problem/61405434>
youenn fablet
Comment 3 2020-04-22 09:39:43 PDT
Created attachment 397210 [details] Patch
youenn fablet
Comment 4 2020-04-22 10:05:30 PDT
Created attachment 397214 [details] Patch
youenn fablet
Comment 5 2020-04-22 10:15:42 PDT
Created attachment 397215 [details] Patch
youenn fablet
Comment 6 2020-04-22 10:34:43 PDT
Created attachment 397221 [details] Patch
Eric Carlson
Comment 7 2020-04-22 10:46:42 PDT
Comment on attachment 397221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397221&action=review > Source/WebCore/platform/mediastream/mac/ScreenDisplayCapturerMac.mm:56 > + RELEASE_LOG(Media, "CGGetActiveDisplayList() returned error %d when trying to get display count", static_cast<int>(err)); This isn't new, but other logging uses the WebRTC channel. If you made this a member function it could use ERROR_LOG_IF. > Source/WebCore/platform/mediastream/mac/ScreenDisplayCapturerMac.mm:203 > + return DisplayCaptureSourceCocoa::DisplayFrameType { RetainPtr<IOSurfaceRef> { m_currentFrame.ioSurface() } }; This isn't new, but shouldn't we have a lock around access to m_currentFrame since it is changed on another thread?
youenn fablet
Comment 8 2020-04-22 12:36:15 PDT
Created attachment 397237 [details] Patch
youenn fablet
Comment 9 2020-04-23 00:55:22 PDT
Created attachment 397325 [details] Patch for landing
EWS
Comment 10 2020-04-23 01:59:35 PDT
Committed r260561: <https://trac.webkit.org/changeset/260561> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397325 [details].
Aakash Jain
Comment 11 2020-04-23 18:30:17 PDT
Newly added layout test fast/mediastream/getDisplayMedia-max-constraints.html seems to be failing consistently and slowing down ios-wk2 EWS. This issue was also indicated by red ios-wk2 ews bubble.
youenn fablet
Comment 12 2020-04-24 00:48:31 PDT
(In reply to Aakash Jain from comment #11) > Newly added layout test > fast/mediastream/getDisplayMedia-max-constraints.html seems to be failing > consistently and slowing down ios-wk2 EWS. This issue was also indicated by > red ios-wk2 ews bubble. They should have been skipped on iOS
youenn fablet
Comment 13 2020-04-24 00:51:49 PDT
Reopening to attach new patch.
youenn fablet
Comment 14 2020-04-24 00:51:52 PDT
Created attachment 397434 [details] Patch
EWS
Comment 15 2020-04-24 03:36:00 PDT
Committed r260638: <https://trac.webkit.org/changeset/260638> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397434 [details].
Note You need to log in before you can comment on or make changes to this bug.