Summary: | getDisplayMedia is not respecting aspect ratio with max constraints | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
youenn fablet
2020-04-22 08:41:50 PDT
Created attachment 397209 [details]
Patch
Created attachment 397210 [details]
Patch
Created attachment 397214 [details]
Patch
Created attachment 397215 [details]
Patch
Created attachment 397221 [details]
Patch
Comment on attachment 397221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397221&action=review > Source/WebCore/platform/mediastream/mac/ScreenDisplayCapturerMac.mm:56 > + RELEASE_LOG(Media, "CGGetActiveDisplayList() returned error %d when trying to get display count", static_cast<int>(err)); This isn't new, but other logging uses the WebRTC channel. If you made this a member function it could use ERROR_LOG_IF. > Source/WebCore/platform/mediastream/mac/ScreenDisplayCapturerMac.mm:203 > + return DisplayCaptureSourceCocoa::DisplayFrameType { RetainPtr<IOSurfaceRef> { m_currentFrame.ioSurface() } }; This isn't new, but shouldn't we have a lock around access to m_currentFrame since it is changed on another thread? Created attachment 397237 [details]
Patch
Created attachment 397325 [details]
Patch for landing
Committed r260561: <https://trac.webkit.org/changeset/260561> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397325 [details]. Newly added layout test fast/mediastream/getDisplayMedia-max-constraints.html seems to be failing consistently and slowing down ios-wk2 EWS. This issue was also indicated by red ios-wk2 ews bubble. (In reply to Aakash Jain from comment #11) > Newly added layout test > fast/mediastream/getDisplayMedia-max-constraints.html seems to be failing > consistently and slowing down ios-wk2 EWS. This issue was also indicated by > red ios-wk2 ews bubble. They should have been skipped on iOS Reopening to attach new patch. Created attachment 397434 [details]
Patch
Committed r260638: <https://trac.webkit.org/changeset/260638> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397434 [details]. |