Bug 21084

Summary: Make concept of children cross-platform on ScrollView
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: PlatformAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 21083    
Attachments:
Description Flags
Patch
none
patch #2 sam: review+

Dave Hyatt
Reported 2008-09-24 17:23:34 PDT
Move the m_children member and children() accessors to FrameView, along with any methods of ScrollView that need to access children.
Attachments
Patch (19.57 KB, patch)
2008-09-24 23:56 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
patch #2 (22.02 KB, patch)
2008-09-25 00:01 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2008-09-24 23:56:39 PDT
Created attachment 23782 [details] Patch
Dave Hyatt
Comment 2 2008-09-25 00:01:52 PDT
Created attachment 23783 [details] patch #2
Sam Weinig
Comment 3 2008-09-25 00:07:57 PDT
Comment on attachment 23783 [details] patch #2 >+ Reviewed by NOBODY (OOPS!). I AM A SOMEBODY! >+ const HashSet<Widget*>* children() const { return &m_children; } Ick, But I guess this has been here a while. >- void removeChild(Widget*); >- >+ Whitespace added. Looks good. I think the implementations of addChildPlatformWidget and removeChildPlatformWidget should assert that the widget is a platform widget, just to be safe. r=me
Dave Hyatt
Comment 4 2008-09-25 00:39:38 PDT
Fixed in r36886.
Note You need to log in before you can comment on or make changes to this bug.