Bug 210838

Summary: Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, drousso, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 205434    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Devin Rousso 2020-04-21 18:54:20 PDT
# STEPS TO REPRODUCE
1. inspect any page with a WebGL/WebGPU <canvas>
2. go to the Graphics Tab
3. select the WebGL context or WebGPU device
4. select a shader program in the navigations sidebar
 => the shader's contents are shown and the navigation sidebar collapses
Comment 1 Devin Rousso 2020-04-21 19:11:25 PDT
Created attachment 397159 [details]
Patch
Comment 2 Joseph Pecoraro 2020-04-21 20:35:20 PDT
Comment on attachment 397159 [details]
Patch

r=me
Comment 3 BJ Burg 2020-04-21 21:10:13 PDT
Comment on attachment 397159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397159&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:1404
> +        || representedObject instanceof WI.AnimationCollection

Thank you for newlines.
Comment 4 EWS 2020-04-21 21:27:33 PDT
Committed r260502: <https://trac.webkit.org/changeset/260502>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397159 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-21 21:28:15 PDT
<rdar://problem/62153943>