Bug 210832

Summary: [JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigIntUse
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-04-21 17:35:13 PDT
[JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigIntUse
Attachments
Patch (13.43 KB, patch)
2020-04-21 17:42 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-21 17:42:26 PDT
Created attachment 397151 [details] Patch
Mark Lam
Comment 2 2020-04-21 19:13:51 PDT
Comment on attachment 397151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397151&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:422 > void SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq(Node* node, bool invert) Since we may now need to speculate for AnyBigIntUse, the name nonSpeculativeNonPeepholeStrictEq (and its caller nonSpeculativeStrictEq) is now inaccurate. I suggest changing them to genericNonPeepholeStrictEq and genericStrictEq respectively. "Generic" here being the generic JSValue case. Or perhaps genericJSValueNonPeepholeStrictEq and genericJSValueStrictEq?
Yusuke Suzuki
Comment 3 2020-04-21 19:17:27 PDT
Comment on attachment 397151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397151&action=review >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:422 >> void SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq(Node* node, bool invert) > > Since we may now need to speculate for AnyBigIntUse, the name nonSpeculativeNonPeepholeStrictEq (and its caller nonSpeculativeStrictEq) is now inaccurate. I suggest changing them to genericNonPeepholeStrictEq and genericStrictEq respectively. "Generic" here being the generic JSValue case. Or perhaps genericJSValueNonPeepholeStrictEq and genericJSValueStrictEq? Nice catch! We should use genericJSValueNonPeepholeStrictEq / genericJSValueStrictEq. Fixed.
Yusuke Suzuki
Comment 4 2020-04-21 19:48:31 PDT
Run JSC tests locally.
Yusuke Suzuki
Comment 5 2020-04-21 19:54:34 PDT
Committed r260490: <https://trac.webkit.org/changeset/260490>
Radar WebKit Bug Importer
Comment 6 2020-04-21 19:55:15 PDT
<rdar://problem/62149170>
Yusuke Suzuki
Comment 7 2020-04-21 21:20:00 PDT
Committed r260501: <https://trac.webkit.org/changeset/260501>
Note You need to log in before you can comment on or make changes to this bug.