Summary: | [JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigIntUse | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-04-21 17:35:13 PDT
Created attachment 397151 [details]
Patch
Comment on attachment 397151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397151&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:422 > void SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq(Node* node, bool invert) Since we may now need to speculate for AnyBigIntUse, the name nonSpeculativeNonPeepholeStrictEq (and its caller nonSpeculativeStrictEq) is now inaccurate. I suggest changing them to genericNonPeepholeStrictEq and genericStrictEq respectively. "Generic" here being the generic JSValue case. Or perhaps genericJSValueNonPeepholeStrictEq and genericJSValueStrictEq? Comment on attachment 397151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397151&action=review >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:422 >> void SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq(Node* node, bool invert) > > Since we may now need to speculate for AnyBigIntUse, the name nonSpeculativeNonPeepholeStrictEq (and its caller nonSpeculativeStrictEq) is now inaccurate. I suggest changing them to genericNonPeepholeStrictEq and genericStrictEq respectively. "Generic" here being the generic JSValue case. Or perhaps genericJSValueNonPeepholeStrictEq and genericJSValueStrictEq? Nice catch! We should use genericJSValueNonPeepholeStrictEq / genericJSValueStrictEq. Fixed. Run JSC tests locally. Committed r260490: <https://trac.webkit.org/changeset/260490> Committed r260501: <https://trac.webkit.org/changeset/260501> |